On Mon, Jul 31, 2023 at 12:41:19PM +0200, Florian Schmaus wrote:
> With 59dbfb80f748 ("cargo.eclass: Add variable alternative to
> $(cargo_crate_uris)") the _cargo_set_crate_uris function was
> introduced. This function runs when the elcass is inherited and sets
> CARGO_CRATE_URIS.
>
> Ebuilds that use $(cargo_crate_uris) in SRC_URI will again invoke this
> function, even though CARGO_CRATE_URIS is already set. Avoiding this
> unnecessary computation reduces the ebuild source time of
> app-shells/nushell-0.83.0 from 21 ms to 14 ms.
Note that pkgcheck (just) gained a check for this, ebuilds should
get fixed in time which would makes this change only an interim
thing and imo not all that worth it.
Aka:
app-shells/nushell$ pkgcheck scan
app-shells/nushell
SuboptimalCratesSeparator: version 0.82.0: line: 9: using - as name-version
separator in CRATES is suboptimal, use name@version instead
SuboptimalCratesURICall: version 0.82.0: line: 601: calling
'$(cargo_crate_uris)' is suboptimal, use '${CARGO_CRATE_URIS}' for global
CRATES instead
SuboptimalCratesURICall: version 0.83.0: line: 574: calling
'$(cargo_crate_uris)' is suboptimal, use '${CARGO_CRATE_URIS}' for global
CRATES instead
--
ionen
signature.asc
Description: PGP signature
