On Tue, 2022-11-29 at 17:31 -0500, Mike Gilbert wrote:
> On Tue, Nov 29, 2022 at 5:14 PM James Le Cuirot <ch...@gentoo.org> wrote:
> >
> > On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote:
> > > This avoids some unnecessary Makefile logic and gives a nice speed up.
> > >
> > > Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my
> > > AMD Phenom II. After, it takes 3 to 4 seconds.
> > >
> > > Signed-off-by: Mike Gilbert <flop...@gentoo.org>
> > > ---
> > > eclass/linux-info.eclass | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
> > > index fc125b0d751..3e64cb9457a 100644
> > > --- a/eclass/linux-info.eclass
> > > +++ b/eclass/linux-info.eclass
> > > @@ -238,7 +238,9 @@ getfilevar() {
> > > # Pass dot-config=0 to avoid the config check in kernels
> > > prior to 5.4.
> > > [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; }
> > > echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \
> > > - nonfatal emake -C "${basedname}"
> > > --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s
> > > -f - 2>/dev/null
> > > + nonfatal emake -C "${basedname}"
> > > --no-print-directory M="${T}" \
> > > + dot-config=0 need-config= need-compiler= \
> > > + ${BUILD_FIXES} -s -f - 2>/dev/null
> > >
> > > ARCH=${myARCH}
> > > fi
> >
> > I'm confused. Breaking up the line makes it faster?
>
> The change is stated in the email subject.
>
Heh, sorry. I need more sleep.
signature.asc
Description: This is a digitally signed message part
