Hi All,

Currently checks for kernel options etc happen in pkg_setup, would it be
possible to move this to pkg_pretend?

Motivation:  pkg_setup executes just prior to unpack, so if it fails
here it could be after a lot of other work has already gone into other
packages, breaking the full merge, it would thus be better to break early.

A couple of packages (dahdi included, although, in-prep commit changes
that to match the eclass) invoke special cases for CHECK_CONFIG,
depending on USE flags, so for example this is going into dahdi now
(variation of what was in pkg_pretend)

use oslec && CHECK_CONFIG+=" ECHO"
linux-mod_pkg_setup

Most of the checks in linux-mod_pkg_setup (like ensuring kernel sources
are prepped) makes sense to perform in pretend rather so that we know
it's sorted prior to the first packages starting to merge, thus reducing
risk of breakage once merges have initiated.

There are a fair number of consumers in-tree that would need to be
validated, but from a quick grep I did this morning looking for examples
I *suspect* most of the consumers will not require any changes.

If there are no objections, and time permitting, I could take a shot at
this and file a PR.

Kind Regards,
Jaco


Reply via email to