> On 18 Dec 2021, at 18:27, Mike Gilbert <flop...@gentoo.org > <mailto:flop...@gentoo.org>> wrote: > > glibc only allows _TIME_BITS=64 when _FILE_OFFSET_BITS=64. > > Signed-off-by: Mike Gilbert <flop...@gentoo.org <mailto:flop...@gentoo.org>> > --- > eclass/flag-o-matic.eclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass > index d262a60b6bb..32119cb9a52 100644 > --- a/eclass/flag-o-matic.eclass > +++ b/eclass/flag-o-matic.eclass > @@ -193,7 +193,8 @@ filter-lfs-flags() { > # _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...) > # _LARGEFILE64_SOURCE: enable support for 64bit variants > (off64_t/fseeko64/etc...) > # _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as > off64_t) > - filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE > -D_LARGEFILE64_SOURCE > + # _TIME_BITS: default to 64bit time_t (requires _FILE_OFFSET_BITS=64) > + filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE > -D_LARGEFILE64_SOURCE -D_TIME_BITS=64 > } > > # @FUNCTION: filter-ldflags > -- > 2.34.1 > >
LGTM and please go ahead so we can move forward with our planning for this (see https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration <https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration> for others). Best, sam
signature.asc
Description: Message signed with OpenPGP
