>>>>> On Sat, 27 Mar 2021, Sam James wrote:
> -if [[ -z ${_AUTOTOOLS_ECLASS} ]]; then
> +if [[ -z ${_AUTOTOOLS_ECLASS} ]] ; then
This just adds unnecessary noise to the git history. We don't have any
policy on whitespace before punctuation marks, but the examples in the
Bash manual don't have whitespace before semicolons. (Several more of
these changes in the reset of the commit.)
> - # Subdirs often share a common build dir #529404. If so, we can't
> safely
> + # Subdirs often share a common build dir, bug #529404. If so, we can't
> safely
Long line.
> - if [[ ${EBUILD_PHASE} != "unpack" && ${EBUILD_PHASE} != "prepare" ]];
> then
> - ewarn "QA Warning: running $1 in ${EBUILD_PHASE} phase"
> + if [[ ${EBUILD_PHASE_FUNC} != "src_unpack" && ${EBUILD_PHASE_FUNC} !=
> "src_prepare" ]] ; then
> + eqawarn "Running '${1}' in ${EBUILD_PHASE_FUNC} phase"
What is wrong with checking EBUILD_PHASE?
Ulrich
signature.asc
Description: PGP signature
