On Wed, 2021-01-06 at 14:25 +0100, Ulrich Mueller wrote:
> > > > > > On Tue, 05 Jan 2021, Michał Górny wrote:
>
> > + # check for the override
> > + local override_name=${ACCT_USER_NAME^^}
> > + local override_var=ACCT_USER_${override_name//-/_}_ID
>
> I wonder about this line. Both hyphen and underscore are valid
> characters in user names.
>
> So, ACCT_USER_FOO_BAR_ID would override the id for both foo_bar and
> foo-bar users.
I don't think this is the problem we need to be worrying about. I mean,
if someone actually created user identifiers that differ only be non-
alnum characters, I think that'd the problem to tackle.
--
Best regards,
Michał Górny
