Re: [gentoo-dev] [PATCH 1/1] python.eclass: add PYTHON_COMPAT_ALLOW_EXTRA_IMPLS

[Michał Górny]

On Thu, 2020-03-26 at 14:13 -0500, William Hubbs wrote:
> This variable is meant to be set in downstream overlays when they need python
> implementations other than the ones we support in the tree.
> It should be a space-separated list of extra implementations.
> 
> Signed-off-by: William Hubbs <willi...@gentoo.org>
> ---
>  eclass/python-utils-r1.eclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
> index aacee5ac35a..4370c7a825f 100644
> --- a/eclass/python-utils-r1.eclass
> +++ b/eclass/python-utils-r1.eclass
> @@ -43,6 +43,8 @@ _PYTHON_ALL_IMPLS=(
>       python2_7
>       python3_6 python3_7 python3_8
>  )
> +[[ -n ${PYTHON_COMPAT_ALLOW_EXTRA_IMPLS[*]} ]] &&
> +     _PYTHON_ALL_IMPLS+=( ${PYTHON_COMPAT_ALLOW_EXTRA_IMPLS} )
>  readonly _PYTHON_ALL_IMPLS
>  
>  # @ECLASS-VARIABLE: PYTHON_COMPAT_NO_STRICT

How is this supposed to work, exactly?  If you scroll to the next
function you'd realize that after this change this 'extra
implementation' will most likely be simultaneously considered supported
and unsupported.

-- 
Best regards,
Michał Górny

signature.asc
Description: This is a digitally signed message part