On Fri, 06 Dec 2019 16:35:53 +0100
Ulrich Müller <u...@gentoo.org> wrote:

>       # The user wants us to leave things be.
> -     if [[ -n ${DONT_MOUNT_BOOT} ]] ; then
> +     if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then
>               return 0
>       fi

The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING
proliferation worrying. Having enough eclasses guard things on it I don't
really know what I am doing :)

For example developer profile sets it on by default and disables perl error
checks. I don't think it's intentional.

I suggest giving this variable a unique specific name. And phase out
${I_KNOW_WHAT_I_AM_DOING} uses from tree completely.

-- 

  Sergei

Reply via email to