On Thu, 13 Jun 2019 15:02:23 +0200 Michael Haubenwallner <ha...@gentoo.org> wrote:
> On 6/13/19 2:45 PM, James Le Cuirot wrote:
> > On Thu, 13 Jun 2019 13:08:15 +0200
> > Michael Haubenwallner <ha...@gentoo.org> wrote:
> >
> >> EAUTORECONF_DEPENDS is non-empty for ppc-aix and x86-winnt only.
> >> Also, unset variable 'arch' after use.
> >> ---
> >> eclass/xorg-3.eclass | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/eclass/xorg-3.eclass b/eclass/xorg-3.eclass
> >> index 6ac90a64d59..f135058fba6 100644
> >> --- a/eclass/xorg-3.eclass
> >> +++ b/eclass/xorg-3.eclass
> >> @@ -116,7 +116,8 @@ WANT_AUTOMAKE="latest"
> >> for arch in ${XORG_EAUTORECONF_ARCHES}; do
> >> EAUTORECONF_DEPENDS+=" ${arch}? ( ${EAUTORECONF_DEPEND} )"
> >> done
> >> -DEPEND+=" ${EAUTORECONF_DEPENDS}"
> >> +unset arch
> >> +BDEPEND+=" ${EAUTORECONF_DEPENDS}"
> >> [[ ${XORG_EAUTORECONF} != no ]] && BDEPEND+=" ${EAUTORECONF_DEPEND}"
> >> unset EAUTORECONF_DEPENDS
> >> unset EAUTORECONF_DEPEND
> >
> > Apart from the unset, the comment doesn't seem to relate to the actual
> > change?
>
> Agreed: The relation should become clear with 15 lines of context.
> Or do you mean something else?
Okay, I get it now. I was also slightly confused by the very similar
variable names.
--
James Le Cuirot (chewi)
Gentoo Linux Developer
pgpI9AKyjHgoG.pgp
Description: OpenPGP digital signature
