On 02/23/19 03:42, Andrew Savchenko wrote:
> On Fri, 22 Feb 2019 23:30:15 -0500 desultory wrote:
>> On 02/20/19 02:36, Michał Górny wrote:
>>> On Wed, 2019-02-20 at 07:20 +0100, Ulrich Mueller wrote:
>>>>>>>>> On Wed, 20 Feb 2019, Matt Turner wrote:
>>>>
>>>>
>>>>> # Don't install libtool archives (even for modules)
>>>>> - prune_libtool_files --all
>>>>> + find "${D}" -name '*.la' -delete || die
>>>>
>>>> Maybe restrict removal to regular files, i.e. add "-type f"?
>>>
>>> I suppose you should have spoken up when people started adopting that
>>> 'find' line all over the place. Though I honestly doubt we're going to
>>> see many packages installing '*.la' non-files.
>>>
>> Just so we are all clear here: your argument is that more fully correct
>> approaches should not be considered in the present and future because
>> less fully correct approaches were implemented in the past? And,
>> further, that since nothing matching a specific pattern happens to come
>> to your mind at he moment, such things do not exist? Perhaps dialing
>> back the rhetoric from 11 and considering feedback as an opportunity to
>> improve existing code is called for in this case, among others.
>
> If we are going to improve code, we should also use find -O3.
>
Please forgive my presumption, but I am going to infer that your comment
was neither meant to display gross ignorance of find (1) nor as a
strawman, but was instead merely a joke; and on that basis ask you a
question.
Why, in your opinion, should it be acceptable for a member of QA to
dismiss commentary on a piece of code on grounds that he knows to be
spurious? Especially code that has been noted, in this very thread, to
encounter cases where it does the wrong thing. Especially when the
proposed change actually removes a class of potential misbehavior of the
code in question.
The proposed change hardly appears to be difficult to implement,
difficult to maintain, expansive in scale, or obscure in nature; so none
of those concerns would appear to apply. Though it does miss at least
one obvious class of potential misbehavior, but that was not the basis
on which it was dismissed.
I eagerly await your insight.
>
> Best regards,
> Andrew Savchenko
>
