On 13-09-2018 18:56:13 +0300, Alon Bar-Lev wrote: > On Thu, Sep 13, 2018 at 6:51 PM Fabian Groffen <grob...@gentoo.org> wrote: > > > > On 12-09-2018 17:46:03 -0700, Matt Turner wrote: > > > On Wed, Sep 12, 2018 at 5:11 PM Rich Freeman <ri...@gentoo.org> wrote: > > > With new GCC comes new warnings, and harmless as the vast majority are > > > they cause the build to break with Werror. > > > > To illustrate harmless: > > warning: this statement may fall through [-Wimplicit-fallthrough=] > > The warning message already has it in it that it's just a pure guess. > > One that exposed a lot of unintentional fallthoughs which were fixed > when reporting to upstream.
Sure that's why the warning is there. But you ignore the point that the same code compiled fine and ran fine for years without problems. > Once again... we should discuss to leave -Werror when policy of > upstream to have no warnings and is maintaining that policy properly > while we at downstream may cooperate and avoid patching upstream but > discuss issues when found. On a developer's system, that would be nice. For ordinary users on the other hand: Leaving -Werror is leaving our users alone in the dark. Don't do that. -- Fabian Groffen Gentoo on a different level
signature.asc
Description: PGP signature
