On 2018-08-21 18:23, Michał Górny wrote: >> Wait, are you saying that I can set USE=-test while FEATURES=test is >> enabled? Is that a valid combination? > > Yes.
The only thing I still don't understand yet: Do we support things like that?
I.e. should we add things like
> if has test ${FEATURES} && ! use test ; then
> eerror "FEATURES=test requires USE=test."
> die "FEATURES=test set but not USE=test"
> fi
if a package's src_test phase requires some conditional stuff or is it
something like "user shoot himself into the foot" so we do *not* care
because we still assume "if FEATURES=test, USE=test is *normally* set"?
Asking from user experience point of view: Imagine a user tries to
emerge a package which will compile multiple hours and src_test just
fails because some conditional stuff didn't run due to USE=-test
accidentally set by the user (in the past or was forgotten).
The code above in an early phase like pkg_setup would prevent such a bad
user experience, not?
--
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5
signature.asc
Description: OpenPGP digital signature
