On Sun, 29 Jul 2018 16:47:47 +0900 Alice Ferrazzi wrote: > Sent from my phone. Please excuse my brevity. > > On Sun, 29 Jul 2018, 16:39 Fabian Groffen, <grob...@gentoo.org> wrote: > > > Completely agreeing with Sergei, with some additional suggestions: > > > > On 28-07-2018 23:14:12 +0100, Sergei Trofimovich wrote: > > > On Sun, 29 Jul 2018 00:40:18 +0300 > > > Mikle Kolyada <zlog...@gentoo.org> wrote: > > > > > > > Hello, > > > > > > > > The Gentoo QA team would like to introduce the following policy that > > > > would be applied to individuals breaking the state and quality of the > > > > main gentoo.git tree > > > > > > > > ( as we do not have this strictly documented yet): > > > > > > > > <policy> > > > > > > > > If recommended > > > > > > It's not called "recommended" but "enforced". > > > > I agree. If you put penalties on these, they become hard rules. I > > think that change should be discussed by the council perhaps?
+1. Also please provide some tool for developers to check for compliance to these rules, e.g. repoman full must perform all these checks. If developers have no way to verify correctness of the code, they can't be held responsible for accidental violation of the rules. > > > > the standard QA > > > > procedure is: > > > > > > > > 1.) Two warnings granted by QA team, after two independent breakages > > > > 2.) Revoking the commit access for 14 days > > > > > > > > These violations will be evaluated individually by all QA team members. > > > > Warnings can be revoked, if during 6 months period a developer makes at > > > > least 20 non trivial changes not producing more breakages. Why 6 months period? Why time frame at all? 20 good commits sounds OK. If you want time frame, then you should set autoexpire of warning as well. What is the definition of non-trivial change? There will be commits which may be seen as trivial by one person (e.g. because it is one-liner) and as non-trivial by another (e.g. because such commit fixes serious bug). > if you want to enforce rules, would be productive to also have extensive > documentation on how to avoid to make such problems. > Better would be to invest more time in something like the breckage checker > script, similar at what mgorny is doing, than adding more ways to block > developers contributions. > > thanks, > Alice Best regards, Andrew Savchenko
pgpmyxUP15S3S.pgp
Description: PGP signature
