Ulrich Müller posted on Tue, 08 May 2018 21:39:16 +0200 as excerpted:

> # @ECLASS: eapi7-ver.eclass
> @@ -58,12 +58,8 @@  # the version string, it is truncated silently.
>  
>  case ${EAPI:-0} in
> -     0|1|2|3|4|5)
> -             die "${ECLASS}: EAPI=${EAPI:-0} not supported";;
> -     6)
> -             ;;
> -     *)
> -             die "${ECLASS}: EAPI=${EAPI} includes all functions from this 
> eclass";;
> +     0|1|2|3|4|5|6) ;;
> +     *) die "${ECLASS}: EAPI=${EAPI} includes all functions from this 
> eclass" ;;
>  esac
>

You're simply continuing what was there before, but since you're working on
it already...

That generic *) case die claim is incorrectly specific for a generic catchall
case.

I'd suggest a 7) case with that specific claim, and an "EAPI Unknown" die
error for the generic *) catchall case.  The error is then clearer if someone
typos EAPI=67 or the like.

+       0|1|2|3|4|5|6) ;;
+       7) die "${ECLASS}: EAPI=${EAPI} includes all functions from this 
eclass" ;;
+       *) die "${ECLASS}: EAPI=${EAPI} Unknown" ;;

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


Reply via email to