On 18/11/2017 00:35, Michael Palimaka wrote:
> On 11/16/2017 02:27 PM, William L. Thomson Jr. wrote:
>> It maybe worth considering switching the default generator in the
>> cmake-utils.eclass from the default of emake to ninja.
>>
>> - : ${CMAKE_MAKEFILE_GENERATOR:=emake}
>> + : ${CMAKE_MAKEFILE_GENERATOR:=ninja}
>>
>> For those with cmake ebuilds you can test this out now via
>>
>> CMAKE_MAKEFILE_GENERATOR="ninja"
>> inherit cmake-utils
> If testing this, please use : ${CMAKE_MAKEFILE_GENERATOR:=ninja} in
> ebuilds unless the emake generator is explicitly known not to work. This
> will preserve user choice if they want to avoid ninja for some reason.
>
In my user opinion this has no place in a ebuild unless upstream clearly
say to use (or evidently use) ninja as it main generator.
In cases where ninja is considered (by upstream) the best option,
Michael suggestion to make it overridable is a very wise one.
In that case, please also remember to depend on ninja
Since other emails (by Christoph and Brian) in this thread make evident
that it's not a drop in replacement, fixing it in the eclass seem a bad
idea, but that probably should be reconsidered when ninja become more
capable.
