On Sun, Nov 05, 2017 at 10:10:32PM +0100, Michał Górny wrote: > > Nits: > > - please stick to ASCII ellipsis. The unicode ellipsis is unreadable in > > some monospace fonts. > Done. Also replaced '—' for consistency. I wasn't even aware you had used a different dash, it was rendered identically here, definitely thanks for fixing that too.
> > Further items inline: > > > Directory tree coverage > > > ----------------------- > I've went for something even more explicit: > | If files or directories that are not otherwise ignored reside > | on a different filesystem, or symbolic links point to targets > | on a different filesystem, they must be explicitly excluded > | via ``IGNORE``. +1, resolves the concern very well, nice and clear. > > > Tree layout restrictions > > > ------------------------ > > 'common' in the second sentence seems odd. What about uncommon > > filenames? Maybe just s/other common filenames/other filenames/. > Done. The idea was to say 'do not put IGNORE for corner cases which are > better handled via PM config' but I guess it's not necessary here. Yes. Generally, IGNORE entries in Manifest should be for files distributed alongside the Manifest. We're say as common special cases, that local/distfiles/packages/lost+found are also known for ignore, since they have previously-defined meaning in the repo (along with the old timestamp files). > > > Non-strict Manifest verification > > > -------------------------------- > Rewritten to: > | It is much more common for users to strip whole packages > | or categories. The ``MISC`` type is not suitable for that, > | and so a dedicated package manager mechanism needs to be developed > | instead; possibly combining it with rsync exclusion list. The same > | mechanism can also handle files that historically used the ``MISC`` > | type. > But it's merely a rationale, so I'd rather not spend another hour trying > to cover every corner case in it. +1. Maybe cover it with a single sentence, "As an example, the package manager may choose to generate both the rsync exclusion list and Manifest IGNORE based on a source list" -- Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation Asst. Treasurer E-Mail : robb...@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136
signature.asc
Description: Digital signature
