On 04/02/2017 05:05 AM, David Seifert wrote:

[[ ${XEMACS_PKG_CAT} ]] || die "XEMACS_PKG_CAT was not defined before inheriting 
xemacs-packages-r1.eclass"
case ${XEMACS_PKG_CAT} in
        standard|mule|contrib)
                ;;
        *)
                die "Unsupported package category in XEMACS_PKG_CAT"
                ;;
esac


I think that the first check is redundant, but it isn't important if you don't feel like changing it.

Elsewhere: quoting the variables when they're used would produce better error messages if somebody puts something stupid in the variables.


Reply via email to