On Wed, 19 Oct 2016 14:15:11 +0200 Kristian Fiskerstrand <k...@gentoo.org> wrote:
> > > > Personally I use it as 'I sign off on the Author's work'. I suppose the > > commit itself is good enough for this but I personally prefer verbosity. > > It also calls out that it wasn't my work. > > > > This sounds more like a reviewed by or acked by? I think the important use-case here is to understand why you can't rely on other headers. The beauty of Signed-Off-By is if you cherry-pick a commit with it, its preserved. Default behaviour: - Author is preserved from first committer - Committer is changed every time the commit itself is rebased, cherry-picked, etc. So if this commit was to get teleported to a different repo, --signoff by would be preserved, as an intermediate between these two. So I think the intent for this is "X reviewed these changes for Gentoo and takes responsibility for them" what text you use to convey that is irrelevant, as long as its used consistently and everyone understands what the text means. git help commmit, emphasis added: > Add Signed-off-by line by the committer at the end of the commit log message. > ***The meaning of a signoff depends on the project***, but it typically > certifies that committer has the rights to submit this work under the same > license and agrees to a Developer Certificate of Origin > (see http://developercertificate.org/ for more information). And I think people get hung up too much on the second half of that statement. Sure, we could use some other header, but this one is standard and part of default git tooling. So its at least practical.
pgpnB6tRp5481.pgp
Description: OpenPGP digital signature
