On 08/20/2016 05:13 AM, Joshua Kinard wrote: > All, > > It looks like that sometime around Linux 3.15, some kind of a quirk was > introduced where a patch that contains the removal of a symlink followed by > the > addition of a file with the same name as the symlink causes patch's --dry-run > phase to fail, which kills 'epatch'. See Bug #507656. > > A workaround was added to kernel-2.eclass, around line 1093, that hardcodes a > check for sys-kernel/git-sources, to avoid this issue. Well, > sys-kernel/mips-sources is also affected by the same issue. I'm close to > releasing a newer mips-sources, having spent the last few months > re-writing/refactoring chunks of old SGI IP27/BRIDGE code, and rather than add > another hardcode to kernel-2, I instead created a new variable, K_FROM_GIT, > that will replace the hardcode. > > When set to a value, it triggers the workaround, which still affects current > kernels. This results in a cleaner implementation instead of a hardcoded > ebuild, should future kernel packages sourced from a git repo get added. > > Patch is attached for review. > > Thanks! >
lgtm, but I'm curious over the targeting of -rc releases. Are the only releases after 15 in the 3.x series -rc? If not, you're going to run into problems where a kernel is >=3.15 but not an rc. Otherwise it seems better than hardcoding it imo. -- Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6
signature.asc
Description: OpenPGP digital signature
