I generally prefer using -std=gnu89 instead of -fgnu89-inline, as GCC might
change some C11 semantics later on. To me -std=gnu89 seems more robust.
David
> On 22 Apr 2016, at 23:39, Mike Frysinger <vap...@gentoo.org> wrote:
>
> On 22 Apr 2016 03:57, Leno Hou wrote:
>> +-extern inline UInt32 blockiter_curr(blockiter *b)
>> +-{
>> +- return b->e->start_block + b->block;
>> +-}
>> +-
>> +-
>> ++extern inline UInt32 blockiter_curr(blockiter *b);
>
> i don't think that's how you want to handle extern inline.
> it doesn't make sense when it's declared this way as there
> is no actual body for gcc to optimisitcally inline.
>
> instead, we should go with what Ubuntu/Debian have: use the
> -fgnu89-inline flag to build since those are the semantics
> this code expects. i've pushed that fix now.
> -mike
