>>>>> On Wed, 27 Jan 2016, Alexis Ballier wrote:

> On Wed, 27 Jan 2016 20:59:21 +0100
> Ulrich Mueller <u...@gentoo.org> wrote:

>> Please find below a patch which will enable EAPI 6 support in
>> latex-package.eclass. The main change is that it won't inherit base
>> any more.

> lgtm, thanks

Pushed to master, with one additional change (see below). Seems better
to have the function explicitly die, especially since for a query
function there won't be any error checking in the caller.

Ulrich

--- a/eclass/latex-package.eclass
+++ b/eclass/latex-package.eclass
@@ -71,12 +71,13 @@
 # DESCRIPTION above)
 SUPPLIER="misc"
 
-case ${EAPI:-0} in
-       0|1|2|3|4|5)
-               # Kept for backwards compatibility
-               latex-package_has_tetex_3() { true; }
-               ;;
-esac
+# Kept for backwards compatibility
+latex-package_has_tetex_3() {
+       case ${EAPI:-0} in
+               0|1|2|3|4|5) return 0 ;;
+               *) die "${FUNCNAME} no longer supported in EAPI ${EAPI}" ;;
+       esac
+}
 
 # @FUNCTION: latex-package_src_doinstall
 # @USAGE: [ module ]

Attachment: pgpXRc27UxenS.pgp
Description: PGP signature

Reply via email to