-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 28/11/15 16:28, Davide Pesavento wrote: >> else - nonfatal ${VIRTUALX_COMMAND} "$@" + >> nonfatal "$@" > > Please take the opportunity to clean this up, possibly only in > EAPI=6 if you don't want to risk breaking existing ebuilds. See bug > 517976 for details. > >> retval=$?
The return value is recorded and gets evaluated correctly. src_test() { virtx false } results in * Scanning for an open DISPLAY to start Xvfb ... debug: virtx: XDISPLAY=1 debug: virtx: /usr/bin/Xvfb :1 -screen 0 1280x1024x24 * Starting Xvfb on $DISPLAY=1 ... debug: virtx: emake "false" * ERROR: app-misc/dummy-1::dummy failed (test phase): * virtx: the emake failed. * * Call stack: * ebuild.sh, line 133: Called src_test * environment, line 2072: Called virtx 'false' * environment, line 2700: Called die * The specific snippet of code: * [[ ${retval} -ne 0 ]] && die "${FUNCNAME}: the ${VIRTUALX_COMMAND} failed."; * Am I missing something? -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWWc1jXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiWGcQAK6VSEgzlaUaJ+AEC/I+M+Rz uHOmaEE005MsTpUf8GoRY35fnMNkICES9QLZjaSjliBJ6H/WdGDGcqm7rg5yx0j5 v12vv3LMrFX2D/+2SkTurMlGj0gOz+F27ted/p9tmJJLf0KcbusPiJvmjybNjNH+ 5ksLdZEdnAj1p9qmXfoJ8IlKHO82GUn2cNS9O0XFW9WhSzmOaE+WOp2hQtX0HzUE Y6vcVjl5ZD+RDvc2+7oFptOQxGyEZdP43JikAEsfISHnjA4AtYHMLjIHvItaVdoD 8qbG5WAwp0fg1BwqNM6G9neAbknKeGIBLXNBx1QxVj3toz3j3QR88RB1nyovGNp2 7LZjEWYW9/jLpXVTLTg+vwsM6IgvehFdErlXEcWR/q/Gk5Q7C86o3oN4RPaQ93HV ElxL24u/j1CW1mFzXTgKbM4rxlD8G/aROxiKAh5+66ywSrW1SRhpHSYJxriioco3 iwUyZmBtfCB40+DAHl3cX+yxQ/pKMiR7oN67fsx3F8LEalorcONq5w2e1d0bVbgs EqdlUqxZKyI6fUK67+rI6Nd2ZBduUpm9mTvJHovPMQ3gK2hyRiE6FkhLf53aMR4S 9cmq1Bmqqw3KGTlIu45gKP6NxUr/+n1dg2LYpZF72eKKhPkNOO68YogKS073VEWc DJGgOFCpJQIV+BLid0VF =Nh/f -----END PGP SIGNATURE-----