On Sat, 21 Nov 2015 18:49:03 -0500 Ian Stakenvicius <a...@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 21/11/15 06:29 PM, NP-Hardass wrote: > > Probably not the ideal solution given that you seem to prefer > > removal of such variables, but a REPODIR variable which is set to > > the directory where the repo is (basically making PORTDIR dynamic > > and setting it on a per package basis) could enable developers > > to reference their repo when needed, allowing variable use in a > > multi repo system. Additionally, if that idea is liked, I think > > an array of the repos masters and/or their dirs (or some > > functions to access that information) could also be useful. Like > > get_masters and get_repo_dir functions. > > > > - From your description here REPODIR would only point to the current > repo, so for licence-file access when the license is in the main > gentoo repo, but the current repo is an overlay, it would still fail. > > Similar cases could occur for eclasses, especially since 'masters' > in repo metadata allows multiple repos to be chained. There's also the eclass-overrides problem. > All told, I think i'm in favour of banning the variables, and > potentially providing getter functions that would output the path of > these files if they need to be accessed -- '$(get_eclasspath > [name])' or $(get_licensepath [name]) or the like. I don't know if > these could be implemented in-eclass or if they would be something > that would have to be added to EAPI7..? get_eclasspath doesn't solve the issue of storing random stuff under eclass/ subdirectories, I think. And if I understand your idea correctly, get_licensepath would still not work for binary packages. -- Best regards, Michał Górny <http://dev.gentoo.org/~mgorny/>
pgpbophwJobiS.pgp
Description: OpenPGP digital signature
