On Sat, 10 Oct 2015 10:09:11 +0200 Michał Górny <mgo...@gentoo.org> wrote:
> Hello, developers. > > I have the pleasure to announce that we have formed a new Reviewers > team [1] for Gentoo. The team is going to assemble developers willing > to perform ebuild reviews and help contributors improve their ebuild > skills. > > The main goal of the team is to handle GitHub pull requests. We are > going to review incoming PRs, communicate with maintainers and merge > them as appropriate. In particular, we're going to help willing > contributors get high-quality, PGP-signed commits into Gentoo, > therefore helping them prepare to become Gentoo developers. This is cool > The side goal is to review current Gentoo commits for major QA > violations and other issues, aiming at improving the quality of > ebuilds in Gentoo and helping other developers using bash, ebuilds > and git effectively. This is completely unrelated: since we've had gentoo-commits ml, every one has been able to do commit reviews easily, and most devs have done so. Self-proclamed reviewers project certainly does not have the monopoly of best practices nor perfect knowledge. I hope they do keep the monopoly of being harassing though :) Also, you should probably focus on what's really important: reviews like "this is weird, care to explain?" or stylistic nitpicks are just a waste of every one time, meaning more important stuff does not get done.
