On Sun, Jul 05, 2015 at 09:05:59AM +0300, Andrew Savchenko wrote: > On Sat, 4 Jul 2015 20:20:23 +0200 Peter Stuge wrote: > > It's important that the review flow is well-understood and efficient. > > This is impossible in our case due to the lack of manpower. > We already have a lot of bugs, patches, stabilization requests > hanging over there for months and even years. Stabilization request > will require at least two developers to participate in each commit. > This will double manpower required at least. Such approach can kill > the whole project.
Agreed. Forcing all commits from developers to go through a code review from another developer before they hit the tree would potentially kill the entire project. I would strongly veto something like this, because we flat out don't have the manpower to keep up with it. > Code review is good at a limited scope, e.g. for non-developers > where we have review anyway. Agreed; I could see something like this being beneficial. William
signature.asc
Description: Digital signature
