On Wed, Jun 10, 2015 at 12:32:54PM -0500, William Hubbs wrote: > On Wed, Jun 10, 2015 at 11:53:28AM -0400, Mike Frysinger wrote: > > On 08 Jun 2015 14:38, William Hubbs wrote: > > > # We depend on dev-vcs/git since it is the most used vcs for Go > > > # packages. However we will not depend on all vcs's Go supports at the > > > # eclass level. If your package, or one of its dependencies, uses > > > # another vcs, please depend on it directly. > > > > > > DEPEND=">=dev-lang/go-1.4.2 > > > dev-vcs/git" > > > > that really isn't what i was suggesting nor does it seem to be justified ? > > Please clarify -- what are you suggesting then? > > The options as I see them are to either: > > 1. try to pick the most common vcs and depend on it. > 2. depend on all vcs's go supports (git, mercurial, svn and bzr). > 3. depend on no vcs's and leave it up to ebuild authors to pull them in > if they choose, although they would have the same issue -- not knowing > for sure which type of hosting their packages or any of their packages' > dependencies use.
I chose option 3, which is where I was to begin with, since we can't know for sure which vcs's are needed. Also, I looked more into "go get" and "go get -d" does not error out if you specify a package correctly, so I have changed the code to die and added documentation about this and the upstream issue where it is being discussed. The other change is to point out in the documentation that EGO_PN can list more than one go package. William
# Copyright 1999-2015 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $
# @ECLASS: golang-vcs.eclass
# @MAINTAINER:
# William Hubbs <willi...@gentoo.org>
# @BLURB: Eclass for fetching and unpacking go repositories.
# @DESCRIPTION:
# This eclass is written to ease the maintenance of live ebuilds
# of software written in the Go programming language.
inherit eutils
case "${EAPI:-0}" in
5)
;;
*)
die "${ECLASS}: Unsupported eapi (EAPI=${EAPI})"
;;
esac
EXPORT_FUNCTIONS src_unpack
if [[ -z ${_GOLANG_VCS} ]]; then
_GOLANG_VCS=1
DEPEND=">=dev-lang/go-1.4.2"
# @ECLASS-VARIABLE: EGO_PN
# @REQUIRED
# @DESCRIPTION:
# This is the import path for the go package(s). Please emerge dev-lang/go
# and read "go help importpath" for syntax.
#
# Example:
# @CODE
# EGO_PN="github.com/user/package"
# EGO_PN="github.com/user1/package1 github.com/user2/package2"
# @CODE
# @ECLASS-VARIABLE: EGO_STORE_DIR
# @DESCRIPTION:
# Storage directory for Go sources.
#
# This is intended to be set by the user in make.conf. Ebuilds must not set
# it.
#
# EGO_STORE_DIR=${DISTDIR}/go-src
# @ECLASS-VARIABLE: EVCS_OFFLINE
# @DEFAULT_UNSET
# @DESCRIPTION:
# If non-empty, this variable prevents any online operations.
# @ECLASS-VARIABLE: EVCS_UMASK
# @DEFAULT_UNSET
# @DESCRIPTION:
# Set this variable to a custom umask. This is intended to be set by
# users. By setting this to something like 002, it can make life easier
# for people who do development as non-root (but are in the portage
# group) and use FEATURES=userpriv.
# @FUNCTION: _golang-vcs_env_setup
# @INTERNAL
# @DESCRIPTION:
# Create EGO_STORE_DIR if necessary and set GOPATH.
_golang-vcs_env_setup() {
debug-print-function ${FUNCNAME} "$@"
local distdir=${PORTAGE_ACTUAL_DISTDIR:-${DISTDIR}}
: ${EGO_STORE_DIR:=${distdir}/go-src}
[[ -n ${EVCS_UMASK} ]] && umask_push $EVCS_UMASK
if [[ ! -d ${EGO_STORE_DIR} ]]; then
(
addwrite /
mkdir -p "${EGO_STORE_DIR}"
) || die "${ECLASS}: unable to create ${EGO_STORE_DIR}"
fi
addwrite "${EGO_STORE_DIR}"
export GOPATH="${EGO_STORE_DIR}"
[[ -n ${EVCS_UMASK} ]] && umask_pop
mkdir -p "${S}" ||
die "${ECLASS}: unable to create ${S}"
return 0
}
# @FUNCTION: _golang-vcs_fetch
# @INTERNAL
# @DESCRIPTION:
# Retrieve the EGO_PN go package along with its dependencies.
_golang-vcs_fetch() {
debug-print-function ${FUNCNAME} "$@"
[[ -z ${EGO_PN} ]] &&
die "${ECLASS}: EGO_PN is not set"
if [[ -n ${EVCS_OFFLINE} ]]; then
export GOPATH="${S}:${GOPATH}"
return 0
fi
[[ -n ${EVCS_UMASK} ]] && umask_push ${EVCS_UMASK}
set -- go get -d -t -u -v -x "${EGO_PN}"
echo "$@"
"$@" || die
# The above dies if you pass repositories in EGO_PN instead of
# packages, e.g. golang.org/x/tools instead of
golang.org/x/tools/cmd/vet.
# This is being discussed in the following upstream issue:
# https://github.com/golang/go/issues/11090
# I am hoping this will be fixed so "go get -d" is successful if
# downloading the top level repository is successful.
[[ -n ${EVCS_UMASK} ]] && umask_pop
export GOPATH="${S}:${EGO_STORE_DIR}"
return 0
}
golang-vcs_src_fetch() {
debug-print-function ${FUNCNAME} "$@"
_golang-vcs_env_setup
_golang-vcs_fetch
}
golang-vcs_src_unpack() {
debug-print-function ${FUNCNAME} "$@"
golang-vcs_src_fetch
}
fi
signature.asc
Description: Digital signature
