On Wed, Jun 10, 2015 at 10:12 AM, Gilles Dartiguelongue <e...@gentoo.org> wrote:
> This is an attempt to fix bug #208047 [1] and bug #444568 [2]
>
> Current fdo-mime eclass is often not used when it should be. I suppose
> this is partly because one has to think too much about whether it is
> needed or not and what to do with the functions.
>
> The proposed solution is to not have to worry about it and just inherit
> it when you have any kind of XDG specifications support and let the
> exported phases do their job in a similar fashion to the gnome
> eclasses.
>
> For now, this covers .desktop and shared mime-info files and creating
> base directory for packages that rely on it one way or another.
>
> This helps solve problems like bug #545128 [3] and others that have
> been covered by previous work resulting in gnome2_environment_reset
> function and similar in other eclasses (cmake-utils, gstreamer, kde4
> -base, mono, mono-env, qt4-*).
> xdg_desktopfiles_savelist() {
> pushd "${D}" &> /dev/null
> export XDG_ECLASS_DESKTOPFILES=$(find 'usr/share/applications' -type f 2>
> /dev/null)
> popd &> /dev/null
> }
Why are you sending stderr from pushd/popd to /dev/null? If they fail,
we want to see that in the log. As well, they should probably die, or
at least return from the function with a non-zero status.
This may also need some adjusting to work on prefix, but I will leave
that for someone else to figure out.
