On 02 Jun 2015 20:47, Michael Palimaka wrote: > On 02/06/15 17:04, Michał Górny wrote: > > Dnia 2015-06-02, o godz. 03:58:35 > > "Michael Sterrett (mr_bones_)" <mr_bon...@gentoo.org> napisał(a): > >> -DEPEND="readline? ( sys-libs/readline ) > >> +DEPEND="readline? ( sys-libs/readline:0 ) > > > > This should be actually := (or :0=) for both deps since gnugo links to > > them. This also applies to your remaining 'warning silencing' commits. > > Why? Blindly adding the subslot dep is a bad idea.
in this particular case, the subslot usage is what we want since we're compiling+linking against it. using readline:0 vs readline is still an improvement though. we also want a subslot on ncurses since we compile+link against it. i think it's pretty uncommon to use readline in a package and not want a subslot. your package would have to be doing something uncommon like dlopening it since the only thing readline provides is a library ... -mike
signature.asc
Description: Digital signature
