Dnia 2013-08-31, o godz. 11:26:30
Ulrich Mueller <u...@gentoo.org> napisał(a):

> >>>>> On Sat, 31 Aug 2013, Michał Górny wrote:
> 
> > And time for a small update. 
> 
> In git-r3_checkout:
> 
>             git --no-pager diff --color --stat \
>                 ${old_commit_id}..${new_commit_id}
> 
> I'd rather omit the --color option, otherwise log files will contain
> escape sequences.

I'd rather leave it. The diff is more for pretty-printing anyway, it
shouldn't really matter in the logs.

> Also it won't harm to make the unpack location configurable, so can we
> please have a variable like EGIT_SOURCEDIR or EGIT_UNPACK_DIR (as it
> was called in git.eclass)?

I've added EGIT_CHECKOUT_DIR :).

Will submit the new version and a diff against v2 in a minute.

-- 
Best regards,
Michał Górny

Attachment: signature.asc
Description: PGP signature

Reply via email to