On 08/09/2013 02:32 AM, Michał Górny wrote: > Hello, > > Just a quick one. > > Currently, the two listed variables are set in make.globals (installed > by portage ebuild); > > COLLISION_IGNORE="/lib/modules/* *.py[co] *\$py.class" > UNINSTALL_IGNORE="/lib/modules/*" > > COLLISION_IGNORE specifies files that will be ignored by > FEATURES=collision-protect when they exist but are not owned by any > package. UNINSTALL_IGNORE specifies files that will not be unmerged. > > By keeping those two in portage, we're basically binding them to > version of portage installed. If we need to ignore more files, we need > to request our users to upgrade portage. > > That's why I'm thinking of moving them to profiles/base/make.defaults. > From what I've tested, the setting there will override make.globals > and therefore the change could be effective from day one, without > the need to upgrade portage. > > I feel like those variables are much alike the QA variables that we > keep in the profiles. > > What do you think? >
Are we sure that this thing really belongs in the profile, rather than something that's defined in ebuilds? Or maybe we should have both? If ebuild devs are forced to use the profile for this, then that global variable could see a lot of growth in the long-term. OTOH, if it's defined at the ebuild level, then it keeps the info more encapsulated, and that may be better particularly for overlay ebuilds. -- Thanks, Zac
