On Thu, Apr 11, 2013 at 7:07 AM, Samuli Suominen <ssuomi...@gentoo.org> wrote: > ^ This will likely cause the patch not to apply, at least with older patch > versions > You should be able to delete this section of the patch to avoid the CVS tag > polluting it
The CVS tags will also create issues during the git migration - we have a bunch of ancient commits that get mangled during conversion largely due to keywords in patch files. I believe -ko will also fix those, but if you don't need the keyword in the patch I'd just avoid it entirely. Brian has been working wonders with fixing as many as possible, but let's not keep adding more (this one will still cause problems since it will be in the commit history even if you fix it - though I suspect in the end we'll just have to live with stuff like this frozen in our history since there really isn't any one-right-way to handle them). IMHO CVS keywords are right up there with 2600Hz when it comes to in-band signaling mechanisms that have unforeseen consequences. Rich
