On Sun, 24 Mar 2013 08:47:41 +0100 Ulrich Mueller <[email protected]> wrote:
> >>>>> On Sat, 23 Mar 2013, Michał Górny wrote:
>
> >> > +multibuild_merge_root() {
> >> > + [...]
> >> > + if type -P lockf &>/dev/null; then
> >> > + # On BSD, we have 'lockf' wrapper.
> >> > + tar -C "${src}" -f - -c . \
> >> > + | lockf "${lockfile}" tar -x -f - -C "${dest}"
> >> > + else
> >> > + [...]
> >> > + cp -a -l -n "${src}"/. "${dest}"/
> >>
> >> You assume that cp is GNU, if there's no lockf. Is it guaranteed that
> >> this is true on all platforms?
>
> > They're all just assumptions. If it breaks somewhere, I'll improve
> > the function.
>
> Maybe explicitly testing for USERLAND would be less fragile? Or use
> tar everywhere?
I prefer something that can boom into face and let us know that it is
broken rather than silent, poor catch-all.
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
