On Sat, 26 Jan 2013 12:30:16 -0300 Alexis Ballier <aball...@gentoo.org> wrote:
> On Sat, 26 Jan 2013 16:08:45 +0100 > Michał Górny <mgo...@gentoo.org> wrote: > > > On Sat, 26 Jan 2013 11:54:44 -0300 > > Alexis Ballier <aball...@gentoo.org> wrote: > > > > > On Sat, 26 Jan 2013 13:11:41 +0100 > > > Michał Górny <mgo...@gentoo.org> wrote: > > > > > > > > (maybe protect it with has_multilib_profile if you wish) > > > > > > > > Well, the current code assumes that no flags == non-multilib > > > > profile. > > > > > > .. and I hit send to quickly: > > > coming back to the skype example, with this assumption, on x86 > > > libitneeds will have no abi useflag enabled while on amd64 it'll > > > have abi_x86_32, so you'll end with deps like: x86? ( libitneeds > > > ) !x86? ( libitneeds[abi_x86_32] ) > > > > Hmm, maybe we should make 'plain x86' use.force the abi_x86_32 flag > > (though keeping it hidden). Then the following dep will work for both > > arches: > > > > libitneeds[abi_x86_32] > > yep, that's the best thing to do IMHO, but then if you want no multilib > -> returns empty list then you'll have to check it with > has_multilib_profile :) Is this really necessary? AFAIU from the endclass standpoint there's no real difference between non-multilib build and build for one ABI. I could even make the multilib code paths used only when at least 2 ABIs are enabled. -- Best regards, Michał Górny
signature.asc
Description: PGP signature