On Mon, 12 Nov 2012 21:34:42 +0100 Fabian Groffen <[email protected]> wrote:
> On 12-11-2012 21:30:20 +0100, Michał Górny wrote:
> > ---
> > gx86/eclass/systemd.eclass | 28 ++++++++++++----------------
> > 1 file changed, 12 insertions(+), 16 deletions(-)
> >
> > diff --git a/gx86/eclass/systemd.eclass b/gx86/eclass/systemd.eclass
> > index 47e342b..bb1ec7f 100644
> > --- a/gx86/eclass/systemd.eclass
> > +++ b/gx86/eclass/systemd.eclass
> > @@ -69,10 +69,9 @@ systemd_get_utildir() {
> > systemd_dounit() {
> > debug-print-function ${FUNCNAME} "${@}"
> >
> > - (
> > - insinto "$(_systemd_get_unitdir)"
> > - doins "${@}"
> > - )
> > + local INSDESTTREE
> > + insinto "$(_systemd_get_unitdir)"
> > + doins "${@}"
>
> Isn't this a bit ugly and assuming knowledge that you better not?
A bit maybe but still less ugly than inducing local scope through
subshelling.
And the knowledge is all in the PMS. It is 100% legit.
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
