On 09/10/12 15:12, Ian Stakenvicius wrote: > On 07/10/12 02:56 PM, justin wrote: >> On 10/7/12 8:19 PM, Chí-Thanh Christopher Nguyễn wrote: >>> justin schrieb: >>>> Hi, >>>> >>>> I want to add following change to fortran-2.eclass to achieve >>>> more simpler usage. >>>> >>>> The patch will make the eclass depend on virtual/fortran so >>>> that no manual addition is needed. Two exception are present, >>>> a) the ebuild has the USE flag fortran, then we check for that, >>>> or b) the FORTRAN_OPTIONAL variable is set, which leaves the >>>> control to the ebuild (e.g. for cases like "lapack? ( >>>> virtual/fortran )"). >>> >>> I suggest that you do something similar to the XORG_DRI variable >>> in xorg-2.eclass. >>> >>> For example: FORTRAN_WANT_COMPILER=no would not add a >>> virtual/fortran dependency FORTRAN_WANT_COMPILER=always would >>> unconditionally depend on virtual/fortran >>> FORTRAN_WANT_COMPILER=useflag would depend on useflag? ( >>> virtual/fortran ) >>> >>> To avoid breaking existing packages, you could default to >>> FORTRAN_WANT_COMPILER=fortran >>> >>> >>> Best regards, Chí-Thanh Christopher Nguyễn >>> >>> > >> Thanks for that suggestion. Please find the new version attached. >> It basically follows what is done in the xorg-2.eclass. But we >> allow a list of USE and don't allow a no, because the eclass itself >> needs a fortran compiler. > >> Thanks, justin > > > Looks better, but it would still be a good idea to have a possibility > of setting FORTRAN_SUPPORT=no so that the eclass can be used without > setting *DEPEND if a dev so desires. > > Right now it looks like FORTRAN_SUPPORT=no would result in > DEPEND+="no? (virtual/fortran)" >
I thought about it, but it makes no sense. There is exactly no need for an ebuild to use this eclass if no fortran support is required. The only purpose of this eclass is to check that F77 and FC are valid fortran compilers. But in order to have this possibility available I will add it. Thanks for commenting, Jusitn
signature.asc
Description: OpenPGP digital signature
