On Thursday 16 August 2012 16:19:44 Michał Górny wrote:
> --- a/eutils.eclass
> +++ b/eutils.eclass
> 
> +# Install all specified <file>s into <directory>. This doesn't modify global
> +# 'insinto' path. Alike doins, calls 'die' on failure in EAPI 4+; in earlier
> +# EAPIs, returns false in that case.

i don't really see the point in differentiating here.  we have plenty of
helpers that have always implicitly called die regardless of the EAPI level,
and it's not like you'd be breaking any existing behavior since no one is
using this already.  and even then, you'd be "breaking" builds that were
already broken.

> +dointo() {
> +     [[ ${#} -gt 2 ]] || die 'Synopsis: dointo <directory> <file> [...]'

"Usage" is the standard prefix, not "Synopsis"

style wise, {} around #/@/1/2/3/4/5/6/7/8/9/? variables is noise imo
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to