On Sun, 24 Jun 2012 03:37:59 +1000
Michael Palimaka <kensing...@gentoo.org> wrote:

> --- cmake-utils.eclass
> +++ cmake-utils.eclass
> @@ -20,0 +21,29 @@
> +# @ECLASS-VARIABLE: LANGS

Please prefix.

> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# In case your application provides various translations, use this 
> variable to specify
> +# them in order to populate "linguas_*" IUSE automatically. Make
> sure that you set this
> +# variable before inheriting cmake-utils eclass.
> +# Example:
> +# @CODE
> +#   LANGS="en el de"
> +# @CODE
> +for x in ${LANGS}; do
> +       IUSE+=" linguas_${x}"
> +done
> +
> +# @ECLASS-VARIABLE: LANGSLONG
> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# Same as above, but this variable is for LINGUAS that must be in
> long format.
> +# Remember to set this variable before inheriting cmake-utils eclass.
> +# Look at ${PORTDIR}/profiles/desc/linguas.desc for details.
> +# Example:
> +# @CODE
> +#   LANGS="de_DE hu_HU"
> +# @CODE

Shouldn't this be LANGSLONG?

> +for x in ${LANGSLONG}; do
> +       IUSE+=" linguas_${x%_*}"
> +done
> +unset x
> +

And how does it exactly differ from LANGS above? Is there a reason
those two can't be coerced into a single variable?

Shouldn't those do something more than setting IUSE? For example,
actually ensuring those LINGUAS will be installed?


-- 
Best regards,
Michał Górny

Attachment: signature.asc
Description: PGP signature

Reply via email to