On 22-02-2012 11:33:55 -0600, Matthew Summers wrote:
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <e...@gentoo.org> 
> wrote:
> > Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
[snip]
> >> -     env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " 
> >> -f2-
> >> +     env LC_ALL=C svn info \
> >> +             ${options} --username "${ESVN_USER}" --password 
> >> "${ESVN_PASSWORD}" \
> >> +             "${target}" | grep -i "^${key}" | cut -d" " -f2-
> >>  }
> >>
> >>  ## -- subversion__get_repository_uri()
> >> --------------------------------------- #
> >
> > I'm not an expert of the subversion eclass, but the diff looks good.
> 
> Why would you want a password in an ebuild? The var ESVN_PASSWORD
> seems like trouble to me.

I've seen some projects that have a "anonymous" or "guest" user with a
trivial/documented password, so I guess it's for cases like those.


-- 
Fabian Groffen
Gentoo on a different level

Attachment: signature.asc
Description: Digital signature

Reply via email to