On 10/11/2011 09:46 PM, Fabian Groffen wrote: > On 11-10-2011 21:34:22 +0300, Samuli Suominen wrote: >> Thanks, the end result of installed files look now OK. Care to reopen >> the stabilization bug? The changes are trivial. > > Shall we stick to the policy and wait 30 days without bugs first?
OK, no hurry. >> I just hope nobody will take an example of the ebuild with code >> duplication (multiple epatch calls), overquoting, redudant use of find >> when rm is more than enough, ... > > I just like the documented way of doing things [1], so I hope many > people will just stick to that for maintainability, in favour of pseudo > efficiency. > > > [1] > http://devmanual.gentoo.org/ebuild-writing/functions/src_prepare/epatch/index.html > This document should be fixed. Any comments about the patches belong to header of those patches, available for possible upstreams as well. Doesn't belong to ebuilds. So it very rarely makes sense to call epatch multiple times, and certainly doesn't improve maintainability. - Samuli
