On Wed, 31 Aug 2011 12:32:03 +0200
Tomáš Chvátal <scarab...@gentoo.org> wrote:

> > gibibytes, mebibytes, tebibytes.
> >
> I preffer binary units over this fancy standard :)
> Even our tools return the binary calculated ones not the decadic ones.

These are binary units, rather those fancy misnamed binary units of
yours. It's not fancy standard, it's the ONLY standard :P.

> # @ECLASS-VARIABLE: CHECKREQS_DISK_USR
> # @DEFAULT_UNSET
> # @DESCRIPTION:
> # How much space in /usr is needed to install the package? (2T)

Not this looks like a insane default :D.

>               [G]) echo $((1024 * ${size})) ;;

just 'G)', 'M)', 'T)'.

>       ebegin "Checking for at least ${sizeunit} ${3}"

What ${3} there? I think you should decide whether to name all vars, or
use numeric ones.

> # @FUNCTION: check-reqs_unsattisfied

docstring not updated.

-- 
Best regards,
Michał Górny

Attachment: signature.asc
Description: PGP signature

Reply via email to