On Tuesday, June 28, 2011 12:37:41 justin wrote:
> On 6/28/11 6:23 PM, Mike Frysinger wrote:
> > On Tuesday, June 28, 2011 02:54:03 Michał Górny wrote:
> >> I think that also a good idea may be to provide an Makefile example,
> >> showing that often sed is unnecessary, and it's enough to do things
> >> like:
> >>
> >> emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}"...
> >
> > this is easily dangerous when it comes to packages (and many do) that
> > append in the Makefile. specifying on the command line blocks those
> > while passing via env works fine. i'm not sure it's appropriate to
> > provide as an example. -mike
>
> There are cases and cases. You are right with what you said. But cases
> where the makefile appends stuff are not the typical cases where a sed
> is applied. Normally sed is used if upstream hardcodes FLAGS we don't
> want.and those packages should get patched and the patch sent upstream which means the sed+cmdline is still unnecessary. -mike
signature.asc
Description: This is a digitally signed message part.
