On Thursday 10 June 2010 23:45:29 Arfrever Frehtes Taifersar Arahesis wrote:
[...]
> This commit only removed some compiler warnings.

This adds a cflag preventing the compiler to make some assumptions on the code 
for its optimisations, hence making the code slower/bigger. While the 
changelog entry will help figuring out why this was added, a comment in the 
ebuild explaining why will be even better.
Once you'll have to dig into 4 years of cvs log to figure out wth a cflag 
filtering/addition was added into an ebuild maybe you'll reconsider your 
opinion.

Please always keep in mind that you're not the only one that will ever commit 
to $package and even less the only one that will have a look at a given 
ebuild.

A.

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to