On Sun, 2010-04-25 at 13:11 +0300, Petteri Räty wrote: > On 04/25/2010 01:06 PM, Ryan Hill wrote: > > On Sat, 24 Apr 2010 20:40:54 +0300 > > Petteri Räty <betelge...@gentoo.org> wrote: > > > >> What do you think about not allowing commits to eclasses without > >> mentioning an another developer who has reviewed and approved the diff > >> in the commit message? There's enough people on gentoo-dev for urgent > >> stuff too. > > > > I think it's a good idea to strongly encourage it, but actually forcing it > > through cvs? No thanks. I'm not tracking down another dev just to fix a > > spelling mistake. :P > > > > > > How did the spelling mistake get there in the first place? A review > system should reduce having them in the first place.
Because the reviewer missed it. gentoolkit-0.3.0 is currently being developed by the user community and I review everything before I commit to the gentoolkit repository. It is amazing, how much still gets through the review process (including spelling errors). While reviews will catch a lot of stuff, they won't catch everything. Finally, my opinion is in line with Ryan's. Strongly encourage it, but do not force it through cvs. Regards, Paul
