On 02/14/2010 11:36 PM, Gilles Dartiguelongue (eva) wrote:
>   Added:                vala-0.7.10.ebuild
> Index: vala-0.7.10.ebuild
>
> #FIXME: flex and bison are in "base" profile,
> # so why put them into DEPEND ?
>
>       sys-devel/flex
>       || ( sys-devel/bison dev-util/byacc dev-util/yacc )

Because implicit depends are bad[1] and flex shouldn't be in system
set[2]. Please remove the comment from the ebuild so nobody accidentally
drops the required (and correct) depends.

[1]
http://blog.flameeyes.eu/2009/09/09/proper-dependencies-aren-t-overcomplex
[2] http://bugs.gentoo.org/show_bug.cgi?id=221311

Thanks, Samuli

Reply via email to