El 07/02/2010, a las 18:19, Zac Medico <zmed...@gentoo.org> escribió:
On 02/07/2010 01:10 PM, Stelian Ionescu wrote:
Wouldn't it be a good idea to use "set -e" in the ebuild
environment ?
I've seen cases of ebuilds calling epatch without inheriting from
eutils
which compiled and installed (apparently) fine but possibly broken
binaries. Examples of cases where "set -e" would have helped: 303849,
297063, 260279, 221257,
https://bugs.gentoo.org/buglist.cgi?quicksearch=command+not+found
and perhaps others I haven't managed to find in bugzilla
I don't know what kind of side-effects set -e would introduce, but
we can easily add a repoman check for epatch calls without eutils
inherit.
Portage already does a search of the build log for 'command not
found' messages and generates a QA warnings. Set
PORTAGE_ELOG_CLASSES="${PORTAGE_ELOG_CLASSES} qa" in /etc/make.conf
if you want to have those warnings logged.
But, shouldn't it die when a command isn't found? Not only with epatch.
--
Thanks,
Zac
