Hi, Joe Sapp <nixpho...@gentoo.org>: > Anyways, a diff would be useless so I've attached the proposed eclass > [2].
Looks fine so far. What puzzled me is the documentation of the SLOT
variable. What is the motivation to do so?
* Sometimes you give a default on undefined ROOT variable, sometimes
not. Please make it consistent for cosmetic reasons.
* addwrite "${ROOT}/root/.gnome2": Is this unconditionally necessary?
Or could a "boolean" in the ebuild be set to activate it?
* DISPLAY variable export could be done with the assignment. Or is the
export always needed?
* Is the file name LICENSE always used for the license or is COPYING
for example also possible?
* einfo "Installing Control ${CTRL_DIRNAME}": Is not mirrored in the
desklet branch of the if clause.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
<URL:http://gentoo.faulhammer.org/>
signature.asc
Description: PGP signature
