Re: [gentoo-dev] Re: perl-module.class review

[Tomáš Chvátal]

Dne pondělí 21 Září 2009 17:29:26 Torsten Veller napsal(a):
> * Ciaran McCreesh <ciaran.mccre...@googlemail.com>:
> > Torsten Veller <t...@gentoo.org> wrote:
> > > +EXPORTED_FUNCTIONS="src_unpack src_compile src_test src_install"
> >
> > You're probably not the only one using this trick, so it might be wise
> > to use PERL_EXPORTED_FUNCTIONS or somesuch to avoid name collisions
> > with other eclasses.
> 
> git and x-modular use EXPORTED_FUNCTIONS and
> cmake and xfconf use EXPF.
> 
> | eclass/git.eclass:EXPORT_FUNCTIONS ${EXPORTED_FUNCTIONS}
> | eclass/x-modular.eclass:EXPORT_FUNCTIONS ${EXPORTED_FUNCTIONS}
> |
> | eclass/cmake-utils.eclass:EXPORT_FUNCTIONS ${EXPF}
> | eclass/xfconf.eclass:EXPORT_FUNCTIONS ${EXPF}
> 
> I'll use PERL_EXPORTED_FUNCTIONS in the perl eclass.
> 
> Thanks :)
> 
I think it is not required
EXPF="src_compile src_test src_install" <- definition, also nulls anything 
what was in it before :]
case ${EAPI:-0} in                     
        2) EXPF="${EXPF} src_configure" ;;
        1|0) ;;                           
        *) die "Unknown EAPI, Bug eclass maintainers." ;;
esac                                                     
EXPORT_FUNCTIONS ${EXPF}  <- export

i used expf cause it was shorter
and in git eclass i was too lazy for adjusting for the shorter name :]

signature.asc
Description: This is a digitally signed message part.