On 20:33 Sun 10 May , Arfrever Frehtes Taifersar Arahesis (arfrever) wrote: > arfrever 09/05/10 20:33:38 > > Modified: subversion.eclass > Log: > Add possibility of not including Subversion in DEPEND. > Run 'svn upgrade' to automatically upgrade working copies.
A good entry also explains the *reason* for doing something. Anyone could read the code and see what changed, but the person making the change is the only person who knows exactly why. > Revision Changes Path > 1.67 eclass/subversion.eclass > > file : > http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/subversion.eclass?rev=1.67&view=markup > plain: > http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/subversion.eclass?rev=1.67&content-type=text/plain > diff : > http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/subversion.eclass?r1=1.66&r2=1.67 > -EXPORTED_FUNCTIONS="src_unpack pkg_preinst" > case "${EAPI:-0}" in > - 2) EXPORTED_FUNCTIONS="${EXPORTED_FUNCTIONS} src_prepare" ;; > - 1|0) ;; > - *) die "Unknown EAPI, Bug eclass maintainers." ;; > + 0|1) > + EXPORT_FUNCTIONS src_unpack pkg_preinst > + ;; > + *) > + EXPORT_FUNCTIONS src_unpack src_prepare pkg_preinst > + ;; > esac Might this have been worth mentioning in the commit entry? -- Thanks, Donnie Donnie Berkholz Developer, Gentoo Linux Blog: http://dberkholz.wordpress.com
pgpodiCMRHVSR.pgp
Description: PGP signature
