On Mon, 30 Mar 2009 18:33:48 +0200
Thomas Sachau <to...@gentoo.org> wrote:
> Why do you want to force -j1 here?

Because any package using an old automake has a non-parallel-safe
install.

> And i had this proposal some months ago, which noone argued against
> any more

It, along with the half dozen other variants floating around, are good
starting points, but we need a final solution.

>       if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ];

Uh, yeah. I forgot about that bit. We need that.

>       if [ -n "${DOCS}" ]; then
>               dodoc ${DOCS} || die "dodoc failed"

Spaces... Also, the || die bit for EAPI 3 will be wrong.

>       else
>               for x in AUTHORS ChangeLog NEWS README; do
>                       if [ -e ${x} ]; then

Is -e really better than -s?

-- 
Ciaran McCreesh

Attachment: signature.asc
Description: PGP signature

Reply via email to