On 15:16 Sat 29 Mar , Richard Brown (rbrown) wrote:
> 1.1 dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild
>
> file :
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild?rev=1.1&view=markup
> plain:
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild?rev=1.1&content-type=text/plain
>
> Index: rubygems-1.1.0-r0.ebuild
What was the purpose of bumping this to an -r0? I didn't see any
previous rubygems ebuilds doing this.
I'm probably wrong about this, but my naive impression is that it looks
to me like an attempt to force someone else to bring up the issue that
indeed did come up, rather than doing it yourself.
> dosym /usr/bin/gem18 /usr/bin/gem || die "dosym gem failed"
No big deal, but it would be nice to do a relative symlink here.
> #This is used to update rubygems, do not want.
> rm "${D}/usr/bin/update_rubygems18"
>
> dodoc README
> if use examples; then
> cp -pPR examples "${D}/usr/share/doc/${PF}"
> fi
>
> cp "${FILESDIR}/auto_gem.rb" "${D}"/$(${RUBY} -r rbconfig -e 'print
> Config::CONFIG["sitedir"]')
> doenvd "${FILESDIR}/10rubygems"
>
> if use server; then
> newinitd "${FILESDIR}/init.d-gem_server" gem_server
> newconfd "${FILESDIR}/conf.d-gem_server" gem_server
> fi
Might be nice to die if some of these fail.
> }
>
> pkg_postinst()
> {
> ver=$(${RUBY} -r rbconfig -e 'print Config::CONFIG["ruby_version"]')
Shouldn't this be preserved in the environment from src_install()? Rerunning it
seems like
it could allow a change in ruby version to cause issues.
Thanks,
Donnie
--
gentoo-dev@lists.gentoo.org mailing list
